http://aqualung.factorial.hu SVN commit messages (diffs not included). en http://blogs.law.harvard.edu/tech/rss Sat, 24 Nov 2007 20:00:00 GMT Wed, 26 May 2010 00:15:31 GMT http://aqualung.factorial.hu/img/drop.png http://aqualung.factorial.hu 48 48 Tue, 25 May 2010 +0200 18:39:29 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1142 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1142 Fri, 30 Apr 2010 +0200 13:59:47 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1141 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1141 This patch fixes the problem by launching a new thread and using sleep() for waiting. Thanks to Zoltan Kovacs for investigating the problem and providing the patch. ]]> Sat, 03 Apr 2010 +0200 00:18:28 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1140 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1140 In line with Tom's suggestions, this moves the Title format stuff onto the main General Settings page, and changes the settings to not reload the Lua interpreter every time the settings page is closed. It now only reloads the interpreter if the file name has changed.
To reload the Lua interpreter manually, a playlist menu entry is added. Some other minor restructuring of the playlist menu is also done. ]]> Sat, 03 Apr 2010 +0200 00:17:59 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1139 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1139 No restructuring of the options GUI, yet. This changes the configure output, about box, and aqualung -v output.
While here, rename the ext_title_format.* files to ext_lua.*.
Also, update the documentation to move the programmable title format information to the end with the rest of the extension information. ]]> Tue, 30 Mar 2010 +0200 20:33:08 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1138 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1138 Sun, 28 Mar 2010 +0200 17:22:07 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1137 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1137 Tue, 16 Mar 2010 +0100 11:58:54 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1136 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1136 Thu, 11 Feb 2010 +0100 19:24:19 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1135 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1135 Thu, 11 Feb 2010 +0100 00:19:25 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1134 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1134 Mon, 08 Feb 2010 +0100 18:10:45 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1133 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1133 Mon, 08 Feb 2010 +0100 02:10:08 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1132 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1132 I'm not sure why this didn't cause any problems with my system, but it definitely shouldn't be attempting to acquire the mutex when it already has it.
Fix some end tags in aqualung-doc.xml
Remove some pointless or wrong comments ]]> Mon, 08 Feb 2010 +0100 01:56:46 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1131 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1131 Mon, 08 Feb 2010 +0100 01:39:08 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1130 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1130 Mon, 08 Feb 2010 +0100 01:39:01 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1129 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1129 This is the final piece of the extension support foundation. After this, it's just adding additional functions/hooks/etc, not new types of extensions.
Currently, the only hook supported is track_change, which fires when a new track is cued up. See the included documentation patch for an example.
While here, fix the error message for errors when running a custom keybinding function. ]]> Mon, 08 Feb 2010 +0100 01:38:47 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1128 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1128 Mon, 08 Feb 2010 +0100 01:38:26 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1127 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1127 Previously, the callback received an array of selected files for the playlist. However, it's possible that the menu callback doesn't need such a list. Inside, have the menu callback accept 0 arguments, and if an array of selected filenames is desired, the extension writer can call selected_files(), a global method that gives the same results as the argument previously given to the menu callback. This has the advantage of making the array of selected filenames available both to custom remote commands as well as custom keybindings. ]]> Mon, 08 Feb 2010 +0100 01:38:03 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1126 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1126 This commit adds complete support for custom keybindings to the main window, as well as the ground work for supporting custom keybindings in the playlist and music store windows. I don't use the music store and I embed the playlist in the main window, so I haven't hooked into the keybindings of either of those two separately. It should be fairly simple add support similar to how the main window keybindings are handled.
The custom keybinding support is started with the Ctrl-z or Ctrl-Z keys. When that key combination is received, it signals that the next keypress is a custom keybinding. The custom keybinding can be any keyboard key, as well as any of the shift, control, alt (Mod1), and super (Mod4/Windows) keys. See the included documentation patch for more details. ]]> Mon, 08 Feb 2010 +0100 01:37:38 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1125 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1125 Previously, calling m or l functions outside and after a call to playlist_title or application title caused a pointer dereference for the last fdec used, which is no longer valid.
Also, previously, removing the use of an extension file left the Lua interpreter open and didn't close the command menu (among other issues).
Switch from using lightuserdata and manually keeping track of pointers in the Lua registry for the strings used for menu command function callback arguments, to just using regular userdata. It's much simpler.
While here, make the error messages more consistent.
Also while here, grab the mutex as soon as it is available. Unlikely to have a significant effect, but more correct.
Finally, always create the custom commands playlist menu entry on startup, so that even if there is no extension file used when you are starting Aqualung, adding one after will still add the custom commands to the playlist menu. ]]> Mon, 08 Feb 2010 +0100 01:37:31 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1124 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1124 Before, reloading the Lua interpreter leaked memory for each custom playlist menu entry, because it has to strdup the strings it received from Lua before using them as the pointer arguments in GTK callbacks, but it wasn't keeping track of them.
This commit keeps track of them in the Lua registry, and frees them before closing the interpreter.
It also adds a prototype for add_custom_commands_to_playlist_menu to fix a compiler warning. ]]> Mon, 08 Feb 2010 +0100 01:37:14 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1123 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1123 Previously, the custom playlist command menu entries were fixed on startup, the entries were added directly to the playlist menu. This commit makes it so that custom playlist commands are always on a submenu, and that submenu is torn down and rebuilt every time the lua interpreter is reloaded (when the settings window is saved).
This commit refactors Aqualung.process_playlist_menu into itself and Aqualung.build_playlist_menu. process_playlist_menu will return true if there are custom playlist commands and false otherwise, and no longer takes an argument. build_playlist_menu takes a lightuserdata argument and calls build_menu with it.
The basic strategy for rebuilding the menu is to keep the main playlist menu entry for the custom playlist command submenu hidden by default. If there are custom commands, they are added to the submenu and the main playlist menu entry is shown. Everytime the settings are reloaded, the submenu is destroyed, and rebuilt based on the reloaded .lua file.
Reloading the settings still leaks a small amount of memory, but hopefully that will be fixed soon. ]]> Mon, 08 Feb 2010 +0100 01:36:52 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1122 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1122 Mon, 08 Feb 2010 +0100 01:36:36 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1121 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1121 See the included documentation for usage and an example. Currently, this isn't useful for much, since we haven't added any functions to Lua that the user can call to affect Aqualung's behavior, or even get information from Aqualung.
Remote functions defined by the user currently must accept 0 arguments. This limits the utility, but in order to work around it we'd need to decide on a protocol to use to pass the arguments over the socket to Aqualung.
This commit also partly fixes the reloading of custom playlist menu commands. Previously, saving the settings page (which reloads the Lua interpreter) caused all custom menu settings not to work (and potentially a SEGV). This avoids that but causes a memory leak instead. It is still not possible to add new menu entries dynamically (or remove those that are no longer defined), and fixing that will require some work and potentially a UI change.
This also adds a default case when receiving remote commands, which prints an error message if an unsupported command type is received. ]]> Mon, 08 Feb 2010 +0100 01:36:07 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1120 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1120 Mon, 08 Feb 2010 +0100 01:35:49 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1119 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1119 This is the first step in adding a more general extension layer to Aqualung, beyond simply formatting titles. This commit adds the ability to define custom playlist menu commands (and submenus), with callbacks that call user-written Lua functions.
The basics are described in the documentation patch included in this commit.
To make this and future extension patches easier, I've added default functions to ext_title_format.c in the cases where HAVE_LUA is not defined. This way, such functions can be called in other parts of the code without having to surround them with an ifdef HAVE_LUA.
The attached patch is reflective of the general strategy for adding extension code, which is to write as much of it as possible in Lua itself. It probably should be moved out of a .c file and into it's own file that is statically compiled into the source, but that can be done later.
Currently, the code lacks error checking when retrieving information from Lua, and it's probably possible to crash Aqualung given a poorly coded .lua file. This will be fixed.
In order for extensions to be generally useful, the entire Lua standard library is now added to the embedded interpreter. Previously, only a few libraries were loaded.
Currently, the custom playlist menu gui is only created at startup so you need to restart Aqualung for changes to take effect. Hopefully this can be fixed without much difficulty. ]]> Sun, 07 Feb 2010 +0100 21:34:52 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1118 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1118