http://aqualung.factorial.hu SVN commit messages (diffs not included). en http://blogs.law.harvard.edu/tech/rss Sat, 24 Nov 2007 20:00:00 GMT Sun, 05 Feb 2012 01:15:33 GMT http://aqualung.factorial.hu/img/drop.png http://aqualung.factorial.hu 48 48 Sat, 04 Feb 2012 +0100 11:33:30 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1245 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1245 Ran IWYU audits for missing or unnecessary system includes on Linux and FreeBSD, cleaned up based on the results. ]]> Sat, 04 Feb 2012 +0100 11:32:27 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1244 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1244 Both libcdio and Monkey's Audio Codec enjoy the dubious practice of leaking their autoconf generated macro values into the global namespace. This can cause all sorts of irritating problems, but the least subtle collisions are the PACKAGE* and VERSION macros which are always going to be different from those of our app and hence cause the preprocessor to spew redefinition warnings. So, to work around the braindamage present in these libraries, we take the approach of:
1) undefine any macros that could be present in our own config.h that could legitimately be defined differently in the buggy lib 2) include the headers of the buggy lib 3) undefine all the same macros as #1 again 4) re-include our config.h; thus headers included after the buggy lib and our code will have macros expanded correctly ]]> Sat, 04 Feb 2012 +0100 11:32:07 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1243 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1243 Stop confusing oggz_packet with ogg_packet, they're not the same. Eliminate some dead code in the dec_speex.c packet inspection path. Make sure Ogg and Speex headers are included where they need to be. ]]> Sat, 04 Feb 2012 +0100 11:31:54 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1242 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1242 Make sure Wavpack, and Vorbis codecs include the headers they need. ]]> Sat, 04 Feb 2012 +0100 11:31:36 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1241 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1241 Make sure the JACK headers are included where they're needed, and reorder the OSS headers so linux/soundcard.h is included directly if it exists (glibc on Linux ships sys/soundcard.h which just includes linux/soundcard.h, this made the old #if/elif logic short circuit which is harmless but misleading). ]]> Sat, 04 Feb 2012 +0100 11:31:22 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1240 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1240 As we're not using FLAC/all.h, make sure the headers we include are relevant to what we need, where we need it. Also enable conditional compilation for FLAC metadata support, as it relies heavily on libFLAC routines. ]]> Sat, 04 Feb 2012 +0100 11:31:02 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1239 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1239 Aqualung built with libav/ffmpeg support relies on libavutil so make sure it's installed. ]]> Sat, 04 Feb 2012 +0100 11:30:45 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1238 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1238 Remove a bunch of unused externs and make sure functions that end up compiled by the C++ compiler have C linkage. ]]> Sat, 04 Feb 2012 +0100 11:30:17 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1237 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1237 Again with help from IWYU, make sure our headers are included where they need to be and aren't where they don't. Also, make sure the last header included has the forward declarations for the .c file in question. Remove an unnecessary duplication of the db2lin macro. ]]> Sat, 04 Feb 2012 +0100 11:28:58 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1236 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1236 Ran an audit for missing or unnecessary includes related to the glib, gdk, gtk, libxml2, and pthread libraries. Google's include-what-you-use tool helped out: http://code.google.com/p/include-what-you-use/ ]]> Sat, 04 Feb 2012 +0100 11:27:48 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1235 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1235 Every .c and .cpp file needs to include config.h first thing as it may contain compiler workarounds or definitions that enable C extensions. It's less vital that private header files include it, and doing so will likely just slow builds down as config.h doesn't have an include guard. ]]> Sat, 04 Feb 2012 +0100 11:27:18 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1234 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1234 Technically, macros starting with _ are reserved for the compiler and system headers, so make sure our guard macros and temporary defs are in the AQUALUNG_ namespace. ]]> Sat, 04 Feb 2012 +0100 11:26:07 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1233 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1233 clang and clang-derived applications puke on functions declared within other functions, so avoid doing that. ]]> Sat, 04 Feb 2012 +0100 11:25:56 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1232 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1232 Seems that there isn't a lot of agreement between distros on how to rename the Lua package to support installation of multiple versions simultaneously, which is a pity as it makes our detection code look sort of stupid. Debian uses lua5.1, FreeBSD uses lua-5.1, add support for the latter. ]]> Sat, 04 Feb 2012 +0100 11:25:45 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1231 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1231 On many platforms, the math.h functions like floor, fabs, powf, and so forth, require linking with -lm; if we don't add that to LIBS prior to testing for optional libraries we may get unresolved symbols during detection resulting in false negatives. Case in point, this fixes Musepack detection on FreeBSD. ]]> Sat, 28 Jan 2012 +0100 21:24:34 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1230 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1230 Sun, 22 Jan 2012 +0100 14:33:04 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1229 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1229 Mon, 09 Jan 2012 +0100 21:13:04 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1228 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1228 Allow for build configurations that include sndfile or FLAC support, but exclude libencoder and the Rip CD/Export UI components. ]]> Mon, 09 Jan 2012 +0100 21:12:44 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1227 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1227 Larger JACK setups typically rely on dedicated port management software, the applications themselves need not implement it. This introduces a configuration option to let Aqualung be trimmed for such situations. ]]> Mon, 09 Jan 2012 +0100 21:12:31 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1226 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1226 Use automake's conditionals to only compile loop bar support when its inclusion in the build hasn't been disabled. Also, stop displaying a message claiming that we're checking for loop playback support during configure, there's nothing to check, and the summary is indiciation enough of the builder's intent. ]]> Mon, 09 Jan 2012 +0100 21:12:19 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1225 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1225 Use automake's conditionals to only compile podcast support when its inclusion in the build hasn't been disabled. Also, stop displaying a message claiming that we're checking for podcast support during configure, there's nothing to check, and the summary is indiciation enough of the builder's intent. ]]> Mon, 09 Jan 2012 +0100 21:12:05 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1224 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1224 Use automake's conditionals to only compile LADSPA support when the the required external libraries are available. ]]> Mon, 09 Jan 2012 +0100 21:11:51 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1223 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1223 Use automake's conditionals to only compile CDDB support when libcddb is available. ]]> Mon, 09 Jan 2012 +0100 21:11:38 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1222 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1222 Use automake's conditionals to only compile iRiver iFP support when the required external libraries are available. ]]> Mon, 09 Jan 2012 +0100 21:11:27 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1221 http://aqualung.svn.sourceforge.net/viewvc/aqualung?view=rev&revision=1221 Use automake's conditionals to only compile CDDA support when the GNU libcdio project libraries are available. ]]>